Rewrite test_roll_empty to test_roll_scalar#2220
Merged
ndgrigorian merged 1 commit intomasterfrom Dec 17, 2025
Merged
Conversation
this test had been failing on newer numpy versions and contained undefined behavior
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully. |
Collaborator
antonwolfy
approved these changes
Dec 16, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian, LGTM!
It's helpful to make the tests more stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_roll_emptyamounted to testing if roll is well-behaved on a scalar array. However, this test was designed such that the scalar array came fromwhich does not set the dtype of the empty array and is undefined in the value of the scalar. This meant that with the newest NumPy version, the scalar would be on the scale of
1e-322, which is too precise for some devices, and the test would failthis test uses
np.ones([], dtype="f4")now instead, and is renamed totest_roll_scalarwhich more accurately describes what's being tested